search

firsttris / plugin.video.sendtokodi

:tv: plays various stream sites on kodi using youtube-dl
MIT License
121 stars 27 forks source link

switch to (not updated) progress bar instead of notification #78

Closed nullket closed 1 year ago

nullket commented 1 year ago

This should close https://github.com/firsttris/plugin.video.sendtokodi/issues/73.

Instead of a notification ("Resolving..") with a fixed 5 s length, the plugin now shows the kodi background progress element. This background progress bar is similar to a notification (not a full screen, non blocking). As we have no progress update from yt-dlp we can not update this gui element with a real progress. On my tested skins this would not matter as a progress bar with 0 % still looks much better than a notification with 5 s which is still visible after the video has started.

But before we merge I would like to have somebody (e.g. GautamMKGarg) to test it.

GautamMKGarg commented 1 year ago

I found one issue while testing, otherwise it's working better than before.

https://github.com/firsttris/plugin.video.sendtokodi/pull/78#pullrequestreview-1111455658

nullket commented 1 year ago

Good catch! I added a try except which now also informs the user that there was an issue and where to find more information. On the downside the traceback would now be masked by the try block if not printed (or logged in our case) explicitly. Please test if it works as expected.

GautamMKGarg commented 1 year ago

It's working fine for me now. Thanks and good work