search

firsttris / vscode-jest-runner

Simple way to run or debug one or more tests from context menu, codelens or command plalette
https://marketplace.visualstudio.com/items?itemName=firsttris.vscode-jest-runner
MIT License
265 stars 124 forks source link

Keep Run/Debug buttons shown when failed to parse document #163

Closed keroxp closed 3 years ago

keroxp commented 3 years ago

Run/Debug buttons will disappear when failed to parse document. This behaviour causes visual layout change repeatedly on editing test file. In most cases, there' re no problems for keeping buttons shown in previous position even if document has parsing errors. Pushing buttons simply ends with execution error in that situation.

current Image from Gyazo

after Image from Gyazo

firsttris commented 3 years ago

hey @keroxp good work, thx for your contribution !

firsttris commented 3 years ago

hey @keroxp

its seems some issues came up, take a look here: https://github.com/firsttris/vscode-jest-runner/issues/189

i removed the prevResults solution for now.

if you have an idea how to fix this, dont hesitate to create a new pr from master.

thx for your help

best regards tristan

firsttris commented 3 years ago

there was another issue, probably also related to this approach: https://github.com/firsttris/vscode-jest-runner/issues/180

lishine commented 1 year ago

the layout shift happens stilll...