firsttris / vscode-jest-runner

Simple way to run or debug one or more tests from context menu, codelens or command plalette
https://marketplace.visualstudio.com/items?itemName=firsttris.vscode-jest-runner
MIT License
265 stars 124 forks source link

feat(codelens): add options to display desired codelens #213

Closed ajubin closed 3 years ago

ajubin commented 3 years ago

What

In order to ensure backward compatibility, I've set the defaults as ["run", "debug"] even though I think watch should be in the defaults. I've asked my coworkers, they are more often watch test than debug them.

Test plan

ajubin commented 3 years ago

Hi

here's a draft PR with global idea of the implemenation. I've got couple more question before continuing:

Thanks :)

firsttris commented 3 years ago

im ok with usage and implementation, you did great.

users will probably need to manually reload their window.

ajubin commented 3 years ago

thanks :) i've updated code to add a unit test :)

firsttris commented 3 years ago

good work @ajubin, very clean

ajubin commented 3 years ago

Hi @firsttris , is it possible to merge this for a future release ?

firsttris commented 3 years ago

sure, sorry i was just busy with work stuff.

firsttris commented 3 years ago

since i like your work, i can also offer you to make you collaborator of the project, if you like?

ajubin commented 3 years ago

since i like your work, i can also offer you to make you collaborator of the project, if you like?

Yes, I can help you on some subjects if you like, you can DM on twitter https://twitter.com/Jubinou_ :)