search

firsttris / vscode-jest-runner

Simple way to run or debug one or more tests from context menu, codelens or command plalette
https://marketplace.visualstudio.com/items?itemName=firsttris.vscode-jest-runner
MIT License
265 stars 124 forks source link

support for external native terminal run #258

Closed Avivbens closed 2 years ago

Avivbens commented 2 years ago
firsttris commented 2 years ago

hey @Avivbens

i finally got it merged.

sorry for taking so long, i was in the hospital for some weeks.

Do you want to become Collaborator in the Project? You would get full repo permissions. I need some help to take care of it.

best regards Tristan

Avivbens commented 2 years ago

@firsttris Hi! Hope you're better now 🙏

Sure, I can take a place on the repo, some product excellent changes are needed.

firsttris commented 2 years ago

invited

firsttris commented 2 years ago

@Avivbens

theres a problem with your PR, the project no longer installs under Windows because of the ttab library you used.

can you change it to not use it? otherwise i have to revert this PR.

Avivbens commented 2 years ago

I'll find an alternative. For now, revert the PR so users can use it.

firsttris commented 2 years ago

i found we can let the user manually install ttab, and dont add it to dependencies fixes the problem. since you only used it as cmd command. see here: https://github.com/firsttris/vscode-jest-runner/commit/ac9d67d3b85578d43d256b22ce3bdc2b3e5cc3ce