Closed Avivbens closed 2 years ago
hey @Avivbens
i finally got it merged.
sorry for taking so long, i was in the hospital for some weeks.
Do you want to become Collaborator in the Project? You would get full repo permissions. I need some help to take care of it.
best regards Tristan
@firsttris Hi! Hope you're better now 🙏
Sure, I can take a place on the repo, some product excellent changes are needed.
invited
@Avivbens
theres a problem with your PR, the project no longer installs under Windows because of the ttab library you used.
can you change it to not use it? otherwise i have to revert this PR.
I'll find an alternative. For now, revert the PR so users can use it.
i found we can let the user manually install ttab, and dont add it to dependencies fixes the problem. since you only used it as cmd command. see here: https://github.com/firsttris/vscode-jest-runner/commit/ac9d67d3b85578d43d256b22ce3bdc2b3e5cc3ce