search

firsttris / vscode-jest-runner

Simple way to run or debug one or more tests from context menu, codelens or command plalette
https://marketplace.visualstudio.com/items?itemName=firsttris.vscode-jest-runner
MIT License
264 stars 124 forks source link

Relative path for `jestrunner.projectPath` #306

Closed domsleee closed 1 year ago

domsleee commented 1 year ago

Hello 👋

I wanted to enhance jestrunner.projectPath to accept a path relative to the workspace root.

My use case is a repository where jest needs to be run from a folder that isn't the root (in combination with "Change Directory To Workspace Root"). I'm trying to bundle a .vscode/settings with the repository, so using an absolute path is not ideal for me because developers clone the repo in different folders.

I saw that it was done previously in https://github.com/firsttris/vscode-jest-runner/pull/111 and then later reverted. It looks like this is the relevant commit: https://github.com/firsttris/vscode-jest-runner/commit/60e0d6291e0877fc4e1e78fae4c02d964a6894e3#r107914911.

Seems like the extension has changed a bit since then, what do you think of this change? Thanks

firsttris commented 1 year ago

hey @domsleee, sorry for the late response, i was so bussy with reallife stuff.

your contribution looks very promising and professional. i will try to test and merge it as soon as possible.

would be nice to have someone with your skills as collaborator for vscode-jest-runner.

i could add you as collaborator and give you full repository permission.

best regards Tristan

firsttris commented 1 year ago

i tested it. it worked for me.