search

firsttris / vscode-jest-runner

Simple way to run or debug one or more tests from context menu, codelens or command plalette
https://marketplace.visualstudio.com/items?itemName=firsttris.vscode-jest-runner
MIT License
264 stars 124 forks source link

Support param decorator #308

Closed GP4cK closed 1 year ago

GP4cK commented 1 year ago

Closes https://github.com/firsttris/vscode-jest-runner/issues/260

Upgraded jest-editor-support to support test files using param decorators

GP4cK commented 1 year ago

@firsttris not too sure how to write a test for this. I guess I could create a TextDocument with a test that contains a param decorator and check the result of provideCodeLenses. What do you think?

firsttris commented 1 year ago

hey @GP4cK, thx for your contribution.

will decorators: legacy disable some other feature? because "legacy decorators" sounds like theres also a newer option?

best regards Tristan

GP4cK commented 1 year ago

will decorators: legacy disable some other feature?

I don't think so. It will just load a plugin to support param decorators which are not supported in babel 7. See this issue: https://github.com/jest-community/jest-editor-support/issues/89#issuecomment-1179601980.

For what it's worth, I created a VSIX from my branch and I've been using it since I made the PR and haven't faced any problem.

firsttris commented 1 year ago

alry then lets merge it, sorry for the late response, was bussy with reallife stuff.