search

firtoz / react-three-renderer-fiber

Porting R3R to use React Fiber
MIT License
94 stars 10 forks source link

Add step to readme #55

Closed johnmarinelli closed 6 years ago

johnmarinelli commented 6 years ago

Hey! It's me again. So I had to setup this project on a new machine and ran into problems when I followed the README steps. Specifically, the 

<script src="node_modules/react/umd/react.development.js"></script>
<script src="node_modules/react-dom/umd/react-dom.development.js"></script>

lines in examples/index.html were breaking because it couldn't find the files. This is because yarn doesn't install the dependencies for examples when you run yarn install from the root. It's a small detail but cost me ~45 minutes of trying to find a bug in the webpack config or fiddling with the path in the script src.

toxicFork commented 6 years ago

Hi John, thank you for the PR, it is much appreciated!

I have been meaning to get back to this project and see it to completion, your interest and help is a great motivator.

Apologies for the 45 minutes of lost time.