Contributing to react-three-renderer-fiber

[Methuselah96]

What is the status of the cloth-example branch? If I want to contribute should I do it off of master or off of cloth-example?

[toxicFork]

Hi, thank you for your interest in the project!

I had taken a look yesterday evening, it's currently not working and needs a bit of fixing. The dependencies are out of date and I had checked in some code that I'm trying to use for backwards compatibility with original r3r but the work is incomplete so it won't even compile. If I get a few hours I should be able to get it to a good state again :)

I think the main branch should be less broken. Unfortunately I didn't have much opportunity to keep things up to date. If master doesn't let you do anything with it try to lock down the dependency versions in the package json. I will update this issue when I fix the branches.

On Mon, 16 Jul 2018, 14:23 Nathan Bierema, notifications@github.com wrote:

What is the status of the cloth-example branch on react-three-renderer-fiber? If I want to work on react-three-renderer-fiber should I do it off of master or cloth-example?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/toxicFork/react-three-renderer-fiber/issues/56, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0iLY1-22KjCe7phZFxbofun06ZcJ9_ks5uHJPXgaJpZM4VRHqq .

[toxicFork]

I have pushed some changes to the cloth-example branch. The yarn tdd function works on my win 10 laptop now. Next step is to fix the master branch similarly so some example logic can be tested visually

[toxicFork]

The packages had been upgraded so will need to do a new yarn.

I should consider testing with npm too at some point

[toxicFork]

the cloth brach sort of kind of works (check its readme)

unfortunately it's impossible to contribute to still

[birkir]

Alright thanks for the update man

[Methuselah96]

I got tired of waiting and after a little bit of hacking away at it last night I got some of my old stuff rendering in react-three-renderer-fiber. I built react-three-renderer-fiber from the cloth-example branch and linked it using yarn link and fixed some problems with the build (https://github.com/Methuselah96/react-three-renderer-fiber/tree/packing). It took me a little while to realize that @toxicFork is manually calling the render method in his cloth example, but after I got that figured out and after adding a few props to descriptors I managed to my old reference grid visual back up:

My plan right now is to work on the descriptors and make sure they have at least everything I was using in the old react-three-renderer. Hopefully by then @toxicFork will have had some more time to fix the build and work on the internals to where I don't have to manually call the render method. If @toxicFork doesn't get to that by the time I finish fleshing out the descriptors, then I might take a stab at the internals myself. I have written my own react-three-fiber (https://github.com/BieremaBoyzProgramming/react-three-fiber) that is able to render and animate the basic cube example, but I figured @toxicFork has more experience with writing these things and he's put more work into it then I have, so I'm going to try to contribute to this as much as needed. If it's obvious that @toxicFork won't continue contributing then I might just work on my own renderer for convenience of owning the repo.

[toxicFork]

React-three-fiber looks good :)

Thank you for linking to the packing branch of your fork, it will be helpful for when it can be released.

Re: calling render manually, I had been implementing a way to work around that using the render component but it's not a very nice to use API at the moment (and is probably prone to bugs) ( see https://github.com/toxicFork/react-three-renderer-fiber/blob/master/tests/src/core/render.tsx#L92-L106 )

Regarding whether @toxicFork will or not continue contributing, the day job is still taking a significant amount from my energy so I unfortunately cannot reliably estimate how much time and effort I can spend on side projects.

[Methuselah96]

@toxicFork Would you be willing to let me set up a CI (using Travis or CircleCI) to use for PRs?

[toxicFork]

Sure :) I was planning on having another pass over the prs and code this weekend. Which permissions would you like?

Update for my state: looks like my schedule is still hectic until late October.

[Methuselah96]

I would need admin permissions to add it to Travis. But it's not too hard to set up if you want to do it yourself. If you just go to travis-ci.org and sign in using your GitHub account and activate this repository then I can make a PR with a .travis.yml to get things configured correctly and I wouldn't need any permissions.

Also I got permission to work on this for my senior integration project for college so you can expect a lot of work from me in the next few months.

[toxicFork]

Ah yes; I had set up travis for the original project, I will enable it for this one too :)

Congratulations on the permission on the senior integration project! I hope that I can be of help to you in enabling your success.

[toxicFork]

Travis is now enabled for this repo