search

firtoz / react-three-renderer-fiber

Porting R3R to use React Fiber
MIT License
94 stars 10 forks source link

Finish writing all geometry descriptors #66

Closed Methuselah96 closed 6 years ago

Methuselah96 commented 6 years ago

ParametricBufferGeometry was missing from the types package so I couldn't add it. There were a few other errors with the typings that I tried to work around as best as possible.

toxicFork commented 6 years ago

Very nice way of implementing this! :)

Methuselah96 commented 6 years ago

Did even more simplification and should be as type-safe as possible. I'll be able to simplify createGeometryDescriptor.ts a lot more when we can use TypeScript 3.0 (right now there seems to be an error with @types/webvr-api and TypeScript 3.0 (see https://github.com/Microsoft/TypeScript/issues/26038)).

Methuselah96 commented 6 years ago

Should be able to simplify createGeometryDescriptor.ts a lot when TypeScript 3.1 is released (see https://stackoverflow.com/questions/51737041/mapping-generic-spreaded-argument-types-in-typescript/51737337).

toxicFork commented 6 years ago

This is awesome!

toxicFork commented 6 years ago

And looking forward to TS3.1 too