Fixing minFilter not getting set in TextureDescriptor

firtoz / react-three-renderer

Render into a three.js canvas using React.

MIT License

1.49k stars 155 forks source link

Closed nathanbosse closed 7 years ago

nathanbosse commented 7 years ago

I'm new to this library and submitting pull requests, but I came across minFilter not being set on This seemed to be the easiest way to do it.

toxicFork commented 7 years ago

Thanks for the PR, it looks good! :) I'll add some tests for it too.

toxicFork commented 7 years ago

So as a symbol of transparency, I'll be verbose on my thoughts:

At first I was thinking "ok I'll add tests for it before merging" but I'm trying to eliminate all barriers to entry for productivity.

So I'm now thinking:

this looks good and should work :D
instead of adding tests before merging, merge it, and add a new task to create tests that people can help with
something something contribution guide