search

firtoz / react-three-renderer

Render into a three.js canvas using React.
https://toxicfork.github.com/react-three-renderer-example/
MIT License
1.49k stars 155 forks source link

fixed PropTypes deprecation warning #174

Closed lukas-linhart closed 7 years ago

lukas-linhart commented 7 years ago

This is fixing a deprecation warning about accessing PropTypes via the main React package, as PropTypes have been extracted to a separate package, see release notes: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes

alexhisen commented 7 years ago

What's the hold-up on merging this in?

toxicFork commented 7 years ago

@alexhisen The main problem is my lack of motivation to spend time on the project, on top of lack of free time and perhaps a tiny bit of burnout but deep down I know it's still the motivation. Apologies for that.

When I am able to continue work on this I will be merging this and the other PRs but honestly I don't know when that will be so I cannot make promises.

ashl1 commented 7 years ago

I think the preferable method is using PropTypes from 'prop-types' package, not from 'react/lib/ReactPropTypes'

toxicFork commented 7 years ago

Thanks again for the PR.

Once I merge #187 (and see if I can update react/three even further) I'll update the prop-types package too.