search

firtoz / react-three-renderer

Render into a three.js canvas using React.
https://toxicfork.github.com/react-three-renderer-example/
MIT License
1.49k stars 155 forks source link

Added 'uv' and 'groups' support to BufferGeometryDescriptor #194

Open chiguireitor opened 6 years ago

chiguireitor commented 6 years ago

This fork/branch adds the possibility to use BufferGeometry with UVs and Groups (although assigning different materials for each group is another story).

toxicFork commented 6 years ago

Thanks for the PR :) I think we may need to test to see what happens if for example 3 groups are used first and then that's changed to 2 groups, but I can do that in the merge branch, I think I get the main idea of the PR already :D

chiguireitor commented 6 years ago

Excellent, i'm more concerned about UVs than groups, if you want i can separate that in couple of PRs

toxicFork commented 6 years ago

Yes having a separate PR for them will make it easier to press the merge button :)

chiguireitor commented 6 years ago

Should keep the PRs against master or do you have a development branch?

toxicFork commented 6 years ago

Master is good

toxicFork commented 6 years ago

I'll add in uvs in a commit, for groups that will take some more effort

chiguireitor commented 6 years ago

Yes thanks, sorry for not separating the PRs, project's taking all my time and i have it 'npm link' on my rig X-D

toxicFork commented 6 years ago

Don't worry, I have similar issues :D we need an open source support group

On Fri, 10 Nov 2017, 11:51 Chiguireitor, notifications@github.com wrote:

Yes thanks, sorry for not separating the PRs, project's taking all my time and i have it 'npm link' on my rig X-D

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/toxicFork/react-three-renderer/pull/194#issuecomment-343454052, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0iLVSjq6g8h-TyVpPgja72DTblQNB-ks5s1DjYgaJpZM4PQV9F .