firtoz / react-three-renderer

Render into a three.js canvas using React.
https://toxicfork.github.com/react-three-renderer-example/
MIT License
1.49k stars 155 forks source link

Added interleavedBufferGeometry #207

Closed rclancey closed 6 years ago

toxicFork commented 6 years ago

Hi @rclancey, thanks for the PR, currently the project's focusing on getting it to work with latest version of react but once that is resolved it will be worth to keep this feature in mind, so if you would like to reopen it others can take over the functionality. This may not be in the very short term but it will still be beneficial to the community and be appreciated!

rclancey commented 6 years ago

I actually didn't mean to send this PR to you quite yet. I'm working in a forked repo, and GitHub helpfully assumed I wanted to merge it into the base repo.

When I have something that's actually functional, I'll want to work with you to get it into the mainline. The feature I'm really after is being able to specify arbitrary attributes in the BufferGeometry, as opposed to being limited to the hard coded set that is provided for in (My apologies if there's already a way to do this.)

toxicFork commented 6 years ago

Alright that sounds good :)