search

firtysh / real-time-file-share

Real Time File Share is a web application for sharing files in real time.
https://rtfs.onrender.com/
12 stars 22 forks source link

Create uniform theme across all the pages using any css framework or custom css #50

Closed firtysh closed 1 year ago

ManasaKaza commented 1 year ago

I want to work on this issue under JWOC

ritika728 commented 1 year ago

Hey, I can work on this issue under JWOC

firtysh commented 1 year ago

I want to work on this issue under JWOC

Assigned

firtysh commented 1 year ago

Hey, I can work on this issue under JWOC

Assigned

ManasaKaza commented 1 year ago

@firtysh I made a PR right, you told me to modify just 3 minutes back after giving it a review and you did not even gave me a chance to modify

firtysh commented 1 year ago

@firtysh I made a PR right, you told me to modify just 3 minutes back after giving it a review and you did not even gave me a chance to modify I assigned it to you 5 days back and you made the pr on the last day. And in the issue i clearly mentioned to change all the pages but you changed only few pages. The maximum time limit for a hard issue is 4 days but you don't have any time left so i closed the pr.

ManasaKaza commented 1 year ago

@firtysh Fine!!

ManasaKaza commented 1 year ago

@firtysh I made a PR right, you told me to modify just 3 minutes back after giving it a review and you did not even gave me a chance to modify I assigned it to you 5 days back and you made the pr on the last day. And in the issue i clearly mentioned to change all the pages but you changed only few pages. The maximum time limit for a hard issue is 4 days but you don't have any time left so i closed the pr.

I have modified all the pages except the homepage

firtysh commented 1 year ago

@firtysh I made a PR right, you told me to modify just 3 minutes back after giving it a review and you did not even gave me a chance to modify I assigned it to you 5 days back and you made the pr on the last day. And in the issue i clearly mentioned to change all the pages but you changed only few pages. The maximum time limit for a hard issue is 4 days but you don't have any time left so i closed the pr.

I have modified all the pages except the homepage

Its not just that you haven't modified homepage. you should have used same fonts for all the titles, same font for all the text content, some color scheme and there are lot of things like that.