fisadev / conky-draw

Easily create beautiful conky graphs and draws
GNU General Public License v2.0
145 stars 25 forks source link

Add new features #4

Closed n-serrette closed 7 years ago

n-serrette commented 7 years ago

New Features

Ellipse and Ellipse graph

Close to ring, the main difference is the height and width required properties.

Text

A simple implementation of static and variable text.

Graduations

Add graduations on the elements Three new properties on all elements:

PS

This is my first time working with Lua and cairo, so the code might be dirty

fisadev commented 7 years ago

Thanks for the work on this! Very welcome additions :)

I'll give them a try tomorrow, and then will merge it.

fisadev commented 7 years ago

Hey, I've been testing it, and I found an issue, would you mind taking a look at it so I can merge it with the fix?

The issue is that in a ring_graph example, the bar disappears when I add graduations to the graph. This is the example:

{
    kind = 'ring_graph',
    conky_value = 'fs_used_perc /home/',
    center = {x = 90, y = 375},
    radius = 35,
    background_color = graphs_color,
    background_alpha = 0.3,
    background_thickness = 2, 
    bar_color = graphs_color,
    bar_alpha = 1,
    bar_thickness = 5,
    start_angle = 45,
    end_angle = -225,
    graduated= true,
    number_graduation= 20,
    space_between_graduation=4,
},

Without graduations, it shows a bar with about 60% value. With graduations, it only shows the graduated background, but no bar on top of it showing the value of the graph.

n-serrette commented 7 years ago

I will look at it as soon as I can, Thanks

n-serrette commented 7 years ago

I have fixed the issue. You have made a little mistake on your ring_graph, you have used space_between_graduation instead of angle_between graduation. Maybe I should simplify this by using the same property, what do you think?

fisadev commented 7 years ago

Merged, thanks for the work on this, and sorry for the delay! :)