search

fisadev / vim-isort

Vim plugin to sort python imports using https://github.com/timothycrosley/isort
MIT License
219 stars 32 forks source link

Calling :Isort erases vim marks #22

Closed brookskindle closed 12 months ago

brookskindle commented 6 years ago

Hi Juan,

Thanks for making this plugin, it's been an amazing time saver, especially when having to refactor projects!

I've found that calling :Isort on a file erases the vim marks that I was using in the file, but visually selecting the imports and pressing <ctrl>i doesn't (unless the mark is within the range I want to sort).

quiqueporta commented 3 years ago

Hi! Is this fixed? I have the same problem and select all imports is a little annoying.

Thanks for this plugin :+1:

fisadev commented 3 years ago

Hey! At that point in 2017 I was't able to reproduce the issue. But I'll try again. In the meantime, could you share what version of vim/neovim and isort (the python package) are you using? That could help me narrowing it down :)

quiqueporta commented 3 years ago

I'm using Vim 8.0.1453 and isort 5.5.5, with python3 of course :)

vds2212 commented 12 months ago

I have the same problem. I'm using:

fisadev commented 12 months ago

@vds2212 thanks for your report in this other issue: #40! With that I was able to track down the source of the problem and it's the same in both issues. I'll close this one as duplicated, because the other one has more info on how to reproduce the problem. I'll try a fix, though it will require some big changes to the plugin. I'll post more info in #40 .

fisadev commented 12 months ago

I've just pushed a new version! Let's hope the issues are fixed.

vds2212 commented 12 months ago

I works like a charm. It is now only deleting the marks for the lines that have been changed which is very acceptable to me. I'm in favor of closing the issue.

Thanks you very much for being so reactive! And thanks you for Isort :-)