search

fisadev / vim-isort

Vim plugin to sort python imports using https://github.com/timothycrosley/isort
MIT License
219 stars 32 forks source link

Isort occasionally puts blank line at end of file #6

Closed benbarbour closed 8 years ago

benbarbour commented 9 years ago

Then pylint complains.

fisadev commented 9 years ago

ups, I have to look into it, thanks for reporting the issue

fisadev commented 8 years ago

Adding more info to this: not only the line at the end, but also sometimes it deletes the mandatory 2 empty lines between imports and the rest of the code (pep8), leaving only one line.

w0rp commented 8 years ago

:+1: to this. I keep getting blank lines now and again, which I have to go and then fix.

fisadev commented 8 years ago

A new fix was pushed to master. Can you check if it works? :)

w0rp commented 8 years ago

Sorry for no updates on this. I'll check this if I ever find the time.

benbarbour commented 8 years ago

Seems OK at first blush. Thanks!

Of course, it was intermittent to begin with. I'll keep using it though and if you close this issue it can always be re-opened if it happens again.

fisadev commented 8 years ago

Ok! I'll close it then, and let me know if it comes back again.