fishR-Core-Team / FSA

FSA (Fisheries Stock Assessment) package provides R functions to conduct typical introductory fisheries analyses.
https://fishr-core-team.github.io/FSA/
GNU General Public License v2.0
65 stars 20 forks source link

Standard Weight equation for Redbreast Sunfish and Spotted Sunfish #100

Closed jcdoll79 closed 1 year ago

jcdoll79 commented 1 year ago

Add new standard weight equations for Redbreast Sunfish Leopis auritus and Spotted Sunfish Lepomis punctatus from Bonvechio et al. (in press). https://doi.org/10.1002/nafm.10869

droglenc commented 1 year ago

Jason ... I can not access the article anymore. If you can, can you send it to my gmail and I will do the update. Thanks.

droglenc commented 1 year ago

The authors provide Ws equations from using the RLP, EmP (linear), and EmP (quadratic) methods. They only recommended using the EmP (linear) method. In the past, I have only only include the author-recommended equation into WSlit. Assuming that we still want to do this then the equations to add are:

No lengths for given for English units so I converted from the metric lengths and rounded to what seemed like common units (whole, half, or quarter inches) as I have done for other species and as noted in the documentation for WSlit.


While we are at it we should add their length categories to PSDlit. The values to add are

Note that the authors DID provide English values for the length categories.


Finally, the process by which I update this information is a bit convoluted. I will document here for the future (or in case we want to streamline this).

  1. Enter new values into WSlit.csv in the data-raw folder of the package.
  2. Open script in aaaConvertCSV2RDATA.R in the data-raw folder of the package.
  3. Run line 9 to get a list of all of the CSV files
  4. Uncomment and run line 11 with the number of the file that corresponds to WSlit
  5. Run rest of the lines
  6. Check to make sure that the data on WSlit.rdata in the data folder has been updated
  7. Compile the package
  8. Test to see if WSval() returns the intended values

Repeat this for PSDlit if that was changed.

droglenc commented 1 year ago

Will be updated in v0.9.4.