Closed droglenc closed 3 years ago
Summarize()
is used in several other functions in FSA
, is used in several tests, may generally be a useful quick summary to users (similar to peek()
), and provides some functionality not readily available in base R (e.g., number of valid observations). Mostly to minimize possible breaking changes to other functions I suggest we do NOT deprecate Summarize()
.
We should consider removing the following functions as they are only peripherally related to the purpose of
FSA
and cause some maintenance or performance issues. For some of these we could create a vignette (or the like) that demonstrates how this functionality is better performed with functions from other packages.bootcase
et al. ... was added becausebootCase()
was replaced incar
withBoot()
. Possibly keepconfint.bootCase()
etc but changed toconfint.Boot()
, etc.chooseColors()
andpalletteChoices()
... these should be updated ... there is much more info on properly choosing colors now than I was aware of when I wrote these. These should probably not be exported (i.e., should be treated as internal functions) as there are much better packages for handling colors.compIntercepts()
... this can be replaced withemmeans()
inemmeans
package. This does NOT appear in IFAR.compSlopes()
... this can be replaced withemtrends()
inemmeans
package. This does NOT appear in IFAR.diag()
... this is not used by any other functions ... can just be removed (i.e., moved toFSAmisc
).filterD()
... I used this for teaching (automatically drops unused factor levels after filtering) ... probably not something we ultimately want to maintain.fitPlot()
... this was largely added for teaching purposes ... might be better to teach students how to make these plots manually so that they can transfer that skill to methods not supported byfitPlot()
. This does NOT appear in IFAR.hoCoef()
... I added this only for the purpose of testing that b=3 in a W-L regression ... not sure it has any greater purpose.mapvalues()
... could just teach students to useplyr::mapvalues()
rather than re-exporting it here ... this is not used in any function inFSA
... will need to write an errata for IFAR ... this may allow removingplyr
ImportsplotBinResp()
... I added this for a logistic regression example in my stats class ... pretty hacky ... probably better handled in a more manual way ... this is used infitPlot()
for logistic regressions.residPlot()
... same idea asfitPlot()
... this WILL require an errata for IFAR.Subset()
... has been deprecated for years ... should finally removeSummarize()
... another one I made for teaching ... probably better to teachgroup_by()
withsummarize()
???