A CRAN note (for v0.9.2) indicates that we ask that functions from dplyr and sciplot be imported in FSA. However, with the removal of some deprecated functions from v0.9.1, there are no more imports from these packages.
[x] dplyr is still used in some examples so it should be removed from "imports" and put in "suggests" in the DESCRIPTION file.
sciplot is no longer needed and the following three changes should be made.
[x] Remove library(sciplot) from InstallTester.R
[x] Change \code{\link[sciplot]{se}} to \code{se} on line 773 in FSAUtils.R
[x] Remove sciplot from "imports" in the DESCRIPTION file.
Also note that there was a testing error related to ksTest() on some flavors of machines (brought to our attention by Prof. Ripley on 15-Feb-22).
[x] Modified the test to use the names returned by ks.test() rather than hard-coding the names. [This was tested on the M1 builder on 15-Feb-22 and it appears to have passed.]
droglenc
commented
2 years ago
A CRAN note (for v0.9.2) indicates that we ask that functions from
dplyrandsciplotbe imported inFSA. However, with the removal of some deprecated functions from v0.9.1, there are no more imports from these packages.dplyris still used in some examples so it should be removed from "imports" and put in "suggests" in the DESCRIPTION file.sciplotis no longer needed and the following three changes should be made.library(sciplot)fromInstallTester.R\code{\link[sciplot]{se}}to\code{se}on line 773 inFSAUtils.Rsciplotfrom "imports" in the DESCRIPTION file.Also note that there was a testing error related to
ksTest()on some flavors of machines (brought to our attention by Prof. Ripley on 15-Feb-22).ks.test()rather than hard-coding the names. [This was tested on the M1 builder on 15-Feb-22 and it appears to have passed.]