search

fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
454 stars 298 forks source link

I still found capitalized button labels #1027

Closed tunandras closed 8 years ago

tunandras commented 8 years ago

Shame on me. I can't get rid of them. I'm very sorry. :-(

Upload without "#. I18N: A button label." introduction

admin_media_upload.php (line 263) Control panel => Media => Upload media files GoogleMapsModule.php (line 4193) Control panel => Module => Module administration => Google Maps™ => Geographic data => Upload geographic data Weblate: #2970

And the next ones are mentioned in "Convert button labels to lower-case?" (closed) issue #966

View with "#. I18N: Submit button, on a form" new introduction (on most of the charts' pages)

ancestry.php (line 92) FunctionsPrintFacts.php (line 1028, 1060) I think these are not button labels (in contrast to the state of PO file) GoogleMapsModule.php (line 766) branches.php (line 49) compact.php (line 54) descendancy.php (line 71) familybook.php (line 61) fanchart.php (line 95) hourglass.php (line 62) pedigree.php (line 169) relationship.php (line 85)

Weblate: #3024

Add timeline.php (line 304) Weblate : #212

fisharebest commented 8 years ago

Thanks. I missed these...

tunandras commented 8 years ago

You are welcome! :-)

I have some questions.

There was (and is) a "View" (#. I18N: Submit button, on a form) until now. This name appeared on charts' button. What is it's function now? If I see well, a new "view" came in and replaced it. That took it's function.

And there is a button with a very similar function. It's name is "show" in Lifespans chart. (The only one "show" button on charts' pages.) Don't you want to rename this last one to "view"?

fisharebest commented 8 years ago

I have written some scripts that allow me to update the .PO files. For example, I can create a new translation that based on an existing transation, and mark it "for review".

This is how I update the English text, without losing all the translated text.

But these scripts do not remove old translations, and they do not insert the "I18N: comments". To do that, I would need to rebuild all the .PO files, which requires a lot of server resources.