search

fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
475 stars 301 forks source link

ckeditor: Can't Select Text in Android Editor #2347

Open miqrogroove opened 5 years ago

miqrogroove commented 5 years ago

The 1.7.13 news editor does not allow text highlighting in Chrome for Android. I can long-tap and it will give me a gray background on a single word with some kind of scripted context menu, but for editing sentences or links this is useless.

Not familiar with which editor package is included here. Maybe you can help pass along this concern.

In the meantime, I will switch to Chrome for Windows.

fisharebest commented 5 years ago

We use ckeditor 4.

There is now ckeditor 5.

Maybe this is better on android?

miqrogroove commented 5 years ago

The v4 demo is even worse than on my own site. Definitely an upstream bug.

miqrogroove commented 5 years ago

The v5 demo works much better for me.

https://ckeditor.com/ckeditor-5/demo/

Any plans to include that new package?

fisharebest commented 5 years ago

Any plans to include that new package?

Until one hour ago, I did not know that it existed.

I will investigate....

fisharebest commented 5 years ago

ckeditor5 does not support IE11.

magicsunday commented 5 years ago

Is IE11 support still necessary?

fisharebest commented 5 years ago

IE11 still has over 2% market share.

We are currently using the definition >0.1% and not dead (see package.json) in the build script (see webpack.mix.js).

https://browserl.ist/?q=%3E0.1%25+and+not+dead

miqrogroove commented 5 years ago

And how much market share does Android have?

fisharebest commented 5 years ago

ckEditor5 does not support the view/edit HTML option.

This means that it is impossible to do many things. For example, image maps (I use these on my own site).

See https://github.com/ckeditor/ckeditor5/issues/592

fisharebest commented 5 years ago

There is this comment in the migration guide:

An extremely important aspect to be remembered is that — because of the difference in features — the data produced with CKEditor 4 may not be compatible with CKEditor 5 (which may lead to data loss).

miqrogroove commented 4 years ago

Found this for reference: https://github.com/ckeditor/ckeditor4/issues/2362