search

fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
488 stars 301 forks source link

Routing issue #2630

Closed ddrury closed 5 years ago

ddrury commented 5 years ago

After https://github.com/fisharebest/webtrees/commit/5377b74d62e86ce15153fe4c9d3199a28e3b394f Nothing on the lists menu works, all fail with an error message starting with Argument 3 passed to Fisharebest\Webtrees\Auth::checkComponentAccess() must be an instance of Fisharebest\Webtrees\Tree, null given

fisharebest commented 5 years ago

Previously, some of our variables were a bit "promiscuous", and got stored in various global (or global-like) storage.

e.g. if you added a ged=XYZ query parameter, it would magically end up everywhere.

The default route for modules does not include a {tree} parameter. It's easy to add one (which will fix the problem), but it will also break any module routes that are not tree specific (e.g. pages).

So, I'll need to create two module routes - one for tree-pages and one for admin-pages.

We already have this sort of distinction, based on module action names. Those beginning Admin are admin routes.

fisharebest commented 5 years ago

Actually, I think this is much easier than I thought.

Just create two routes - one for admin pages and one for tree pages.

ddrury commented 5 years ago

As you're doing so much work on routing at the moment would you rather we hang fire on reporting stuff until things stabilise ?

fisharebest commented 5 years ago

Your reports are very helpful - although I don't want to waste too much of your time.

I keep thinking that I'm almost there...

ddrury commented 5 years ago

No problem to me, thought it was wasting your time, anyway I'll keep poking!

------ Original Message ------ From: "Greg Roach" notifications@github.com To: "fisharebest/webtrees" webtrees@noreply.github.com Cc: "David Drury" david@drury.me.uk; "Author" author@noreply.github.com Sent: 15/10/2019 18:05:23 Subject: Re: [fisharebest/webtrees] Routing issue (#2630)

Your reports are very helpful - although I don't want to waste too much of your time.

I keep thinking that I'm almost there...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fisharebest/webtrees/issues/2630?email_source=notifications&email_token=AAAZQQZS2PAR4QR24YAXVBTQOXZ5HA5CNFSM4JA6TNAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJQMJQ#issuecomment-542311974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZQQYFPFAIF2TYNT3GVVLQOXZ5HANCNFSM4JA6TNAA.