fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
454 stars 298 forks source link

The pedigree chart fills empty blocks with repetetive information #282

Closed JustCarmen closed 9 years ago

JustCarmen commented 9 years ago

Where in the chart a block should be empty it is now filled with wrong information.

See: http://dev.webtrees.net/demo-dev/pedigree.php?rootid=i73&show_full=1&PEDIGREE_GENERATIONS=4&talloffset=1

This is the pedigree of Queen Victoria who doesn't have parents in the tree. So all blocks except hers should be empty but instead they are filled with another pedigree which is repeating itself.

melizaa commented 9 years ago

I see the same issue also in http://dev.webtrees.net/demo-dev/module.php?ged=demo&mod=googlemap&mod_action=pedigree_map&rootid=i73

http://dev.webtrees.net/demo-dev/fanchart.php?rootid=i73&ged=demo

http://dev.webtrees.net/demo-dev/compact.php?rootid=i73&ged=demo

melizaa commented 9 years ago

In my test system $record = parent::getInstance($xref, $gedcom_id, $gedcom); in library/WT/Individual.php line 48 returns I1@10 when $xref is of a not defined parent.

In functions_charts.php we fill in lines 426 and 427 false for not defined parents. I see the pedigree chart correctly for not defined parents, if I fill ", instead of false, for not defined parents.

Meliza

melizaa commented 9 years ago

" instead of the false solves the issue also in the other charts.

Meliza

fisharebest commented 9 years ago

False is wrong. We should use either GedcomRecord objects or null.

It seems there were two "falses" that cancelled each other out.