search

fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
451 stars 298 forks source link

Number of children (minor issue) #2839

Open WGroleau opened 4 years ago

WGroleau commented 4 years ago

Add a spouse to an individual. Visit that family. Source says six children but has NO information about any. Add fact "number of children" (NCHI) and enter "6" Save, and the fact shows in the table, but it still says "no children" in the upper left.

fisharebest commented 4 years ago

There are two counts of children.

Do we display both? What if there are more than one NCHI fields. Just the first? All?

Your thoughts?

WGroleau commented 4 years ago

I guess maybe all the NCHI fields should be shown, though having two would be a user error.

But the "no children" is a bit odd-appearing. Maybe "no data on children" would be clearer.

fisharebest commented 4 years ago

though having two would be a user error

It's valid. If you have two sources with different data, then you should record them both.

Maybe just display all the values. NCHI first and actual count second?

Or just the actual count - and a warning sign if there's a conflicting NCHI?

WGroleau commented 4 years ago

What if … Each NCHI shown same as currently down in the table of facts. In the upper left, instead of “X children” have “X children identified” where X is the number of CHIL records. This would make it clearer what each is counting.

fisharebest commented 4 years ago

PGV (and maybe also early versions of webtrees?) used the text "X known children".

IIRC, it was changed to just "X children" after a forum discussion because people were confused by the text.

We could just omit the number, and just say "Children"...

t-karcher commented 4 years ago

I'd suggest the following:

Children according to NCHI Text Remark
Not specified, or equal to the number of recorded children [x] children Number of FAMC entries, as today. Not "known" or "identified", since the number is not disputed anyway.
One number (y), differing from the record count [x] recorded children, [y] total "recorded" as in: has its own record.
NCHI value cannot be interpreted as a single number, or multiple NCHI facts [x] recorded children, possibly more (see facts below)
WGroleau commented 2 years ago

In the middle, instead of "total," I'd say "reported" Or if NCHI has a source, "reported in (source)"