fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
490 stars 301 forks source link

Request: add minister as relationship #4132

Closed TheDutchJewel closed 2 years ago

TheDutchJewel commented 2 years ago

In appElementsRelationIsDescriptor.php there are two types of clergy (priest and rabbi), but no minister.

Is it possible to add minister as relationship?

Norwegian-Sardines commented 2 years ago

I'm not against adding additional relationship types, but the list could get rather lengthy. If you have priest and want to add minister, we should add "pastor" as well. If we have Rabbi, we should add "Kohen" and what about "Imam", "Shaman", "Bhikkhu" and I'm sure more exist!

As this relates to the ASSO.RELA tag and that these terms are also translated to other languages, some form of "User Defined Value" with translation options could also be implemented as a long term solution.

TheDutchJewel commented 2 years ago

My request relates to the CHRistening and MARRriage facts.

In the Christian church these Christian sacraments are ministered/performed by the minister.

mpwt commented 2 years ago

For custom terms, I put them in the English spelling myself in the quoted file and translated them with a custom translation module. Due to the almost unlimited variety of designations, this is probably the easier (and faster) solution.

TheDutchJewel commented 2 years ago

Adding it to webtrees ensures that all users can make use of it without having to work with a translation module themselves.

For myself, an alternative to manually editing the file appElementsRelationIsDescriptor.php might be to use a module to extend the terms.

Is that possible? If so, how does that work?

fisharebest commented 2 years ago

We already have a problem where two items in English have the same translation in other languages - e.g. CHR and BAPM.

I think that Minister and Priest might cause the same problem.

I don't know the difference between these words, so I searched on google. I still don't know the difference. Bu tI found a non-English-speaker asking the difference, because the two words have the same translation in their own language.

https://www.christianforums.com/threads/difference-between-priest-and-a-minister.7851133/

"Priest" and "minister" translates roughly as the same word in my language, but looking at the large variety of Christian "ministers" or "ministries" over the web as they call themselves (though I do doubt the authenticity of some) in English, it leaves me with some confusion. So, when we speak in English, what's the difference between a priest and a minister?

So, I don't think we should add this.

Is that possible? If so, how does that work?

It is straightforward.

1) extend the existing RelationIsDescriptor class and add your own extra definitions 2) create a module which implements CustomTagsInterface 3) add a customTags() method which registers your new class in place of the old class.

If I find time, I will create an example

TheDutchJewel commented 2 years ago

I don't know the difference between these words

One important difference is that the term 'priest' is not used in Protestantism, unlike, for example, Catholicism.

If I find time, I will create an example

Thank You!