search

fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
417 stars 290 forks source link

OpenRouteService modules #4445

Open ric2016 opened 2 years ago

ric2016 commented 2 years ago

There are two modules with the same name "OpenRouteService". This is confusing.

Should they be merged into a single module? They seem to have the same configuration options (API key) anyway.

From their descriptions, it's also not clear what they actually accomplish. They implement ModuleMapGeoLocationInterface and ModuleMapAutocompleteInterface respectively, which both have the same method 'searchPlaceNames'. A bit more documentation would be helpful.

Jefferson49 commented 1 year ago

The "Geonames" module is listed twice as well. I also think it is confusing, because the descriptions are different, but the settings for the two modules seem to be identical. I am wondering if there is a difference in the functionality?

GeoNames twice

fisharebest commented 1 year ago

I am wondering if there is a difference in the functionality?

Placenames - this is used when you type a previously unused place name into a place field, and it autosuggests possible matches.

Locations - this is used on the "manage locations" page to find the latitude/longitude of a named place.

ric2016 commented 1 year ago

I suggest to put these explanations into the module descriptions.