2.0.12 - Collapsing and unfolding citation details

[TheDutchJewel]

When collapsing and unfolding citation details from, say, BIRT, this also works into the events CHR/CREM/BURI.

But not for DEAT, which works separately.

Tested by adding an unlinked individual on the live demo.

Is that intentional, or is it a bug?

[fisharebest]

Not sure what you are seeing. Expand/collapse of DEAT:SOUR is working for me.

[ungeahnt]

When collapsing and unfolding citation details from, say, BIRT, this also works into the events CHR/CREM/BURI. But not for DEAT, which works separately.

This effect occurs also with CHR/CREM/BURI.

You have to enter text in the TEXT or NOTE field and when you save, afterwards the folding functionality is gone.

[TheDutchJewel]

Expand/collapse of DEAT:SOUR is working for me.

For me too, that's not the problem.

When collapsing and unfolding citation details from, say, BIRT, this also works into the events CHR/CREM/BURI.

But not for DEAT, which works separately.

The question is why when collapsing and unfolding citation data from BIRT, for example, the source data also collapses and unfolds events CHR/CREM/BURI, but not on DEAT (which works separately).

[ric2016]

As noted in the original ticket, this is caused by multiple elements in the DOM with the same id attribute (e.g. 'collapse-15'), which should generally be avoided.

[ungeahnt]

Sorry, I misunderstood

[TheDutchJewel]

Not sure what you are seeing. Expand/collapse of DEAT:SOUR is working for me.

_Originally posted by @fisharebest

@fisharebest fisharebest added the cannot reproduce

How to reproduce

1. Add unlinked individual on on live demo.

2. Unfold source citation from BIRT.

Before unfolding source citation from BIRT:

After unfolding source citation from BIRT:

[ric2016]

Is this still unclear? (because it still has the 'cannot reproduce' label) As noted above, the cause are multiple elements with the same id attribute in the DOM.

[fisharebest]

Is this still unclear?

Yes.

I add a new individual.

I open the panels for birth and death.

Both panels have a (collapsed) source-citation.

I click to expand BIRT:SOUR. It expands. I click to expand DEAT:SOUR. It expands. I click to collapse BIRT:SOUR. It collapses. I click to collapse DEAT:SOUR. It collapses.

[fisharebest]

As noted above, the cause are multiple elements with the same id attribute in the DOM.

I don't see any duplicates.

All the IDs (#collapse-XXX) are unique.

[ric2016]

To summarize this comment:

Create a new individual on the demo server. https://dev.webtrees.net/demo-stable/index.php?route=%2Fdemo-stable%2Ftree%2Fdemo%2Fadd-child-to-individual%2Fi1&sex=U

click to expand BIRT:SOUR. (one of its elements has "collapse-15") -> BURI:SOUR expands also - this is the effect this is about. (it probably also expands because one of its elements has the same "collapse-15")

[fisharebest]

Thanks. It depends on which subtags are enabled.

I guess that I was "lucky", and the collapse elements in each fact/event had different positions in my data...

We are using $key. We should probably be using $id[$key] .