search

fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
454 stars 298 forks source link

Only subset of <g7:enumset-ROLE> supported #4754

Open Jefferson49 opened 1 year ago

Jefferson49 commented 1 year ago

Oberserved with webtrees 2.1.16

If using ROLEs in Gedcom 7, webtrees currently only offers a subset of the defined roles in Gedcom 7.

The GEDCOM 7.0.11 specification contains more roles: < g7:enumset-ROLE > CHIL, CLERGY, FATH, FRIEND, GODP, HUSB, MOTH, MULTIPLE, NGHBR, OFFICIATOR, PARENT, SPOU, WIFE, WITN, OTHER

Screenshot: webtrees enum ROLE

fisharebest commented 1 year ago

The code is using the GEDCOM 5.5.1 definition of ROLE_IN_EVENT, not the GEDCOM 7.0 defintion.

Jefferson49 commented 1 year ago

Oh, yes of course. Thanks for the explaination. I forgot for a second that webtrees is logically still working in Gedcom 5.5.1, even if I import and view Gedcom 7 data.

Maybe, it is a compliment for webtrees that the imported Gedcom 7 data already looks so good that I forgot the context :-)

fisharebest commented 1 year ago

I think it is probably a bug. The comment was really to myself, to record my initial investigation.

chtiland commented 2 months ago

Hi !

The code is using the GEDCOM 5.5.1 definition of ROLE_IN_EVENT, not the GEDCOM 7.0 defintion.

GEDCOM 5.5.1 Definition :

ROLE_IN_EVENT

_[ CHIL | HUSB | WIFE | MOTH | FATH | SPOU | ( ) ]_

Indicates what role this person played in the event that is being cited in this context. For example, if you cite a child's birth record as the source of the mother's name, the value for this field is "MOTH." If you describe the groom of a marriage, the role is "HUSB." If the role is something different than one of the six relationship role tags listed above then enclose the role name within matching parentheses.

As I understand, we should be able to add other ROLE limited to 15 chars (braces included I presume) no ?

I still don't understand why there's no role "MAIN" nor for the declarant (eg. on birth act this should be father, mother, an uncle, or anybody else. And when this declarant is not the father, this one is quoted with some information like occupation, age... and so when reporting this information on this other individual -> more or less linked to issue about citation see #5006 )

I'm using Webtrees 2.1.20