fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
492 stars 302 forks source link

ADOP events do not link to Family #4792

Open andrewgoz opened 1 year ago

andrewgoz commented 1 year ago

Saving an adoption event with a family link should behave the same as "Link this individual to an existing family as a child" with an "Adopted" relationship.

For example, when adding an adoption event linking to a family X1234 the following is added to the individual:

1 ADOP
2 FAMC @X1234@

which is correct, but incomplete. There is no 1 FAMC link and nothing is added to the family record. What I expect for the individual would be:

1 ADOP
2 FAMC @X1234@
1 FAMC @X1234@
2 PEDI ADOPTED

and the correspoding family would have (assuming the individual is @X1233):

1 CHIL @X1233@

Note that if 1 FAMC already exists for the individual, then only a 2 PEDI should be added, if one did not already exist. Similarly, the 1 CHIL in the family should only be added if it did not already exist.

zhoueysun commented 1 year ago

I wonder if this is the reason that if the two families are reordered, the labels in the Family Navigator changes: see https://www.webtrees.net/index.php/en/forum/help-for-release-2-1-x/37866-problem-with-labels-in-family-navigator-with-adopted-children#98560

@andrewgoz if you don't think so, I will open a new issue. I was awaiting a comment on the Forum posting, but none was forthcoming.

Norwegian-Sardines commented 1 year ago

The adoption fact and the connection to a family as an adopted child are two different states of existence.

1) having been adopted 2) participating in an adopted family unit

let’s suppose that I want to show an individual was adopted by a family, but I did not want to show in reports or diagrams that that same person was a biological member of a family unit.

I would not want an automatic connection of an individual to the family as a child just because they were adopted.

It is very possible that I want to only maintain “biological family” links but document adoption linkages. This might be most important when adoptions are only by one of the two parents in a family, maybe I want to show a difference when an adoption is made at or near the time of birth vs later in the child’s life by one parent.

zhoueysun commented 1 year ago

@Norwegian-Sardines
So I understand, reordering the family involving the adopted child, with the change in the labels, as shown in the Latest Demo, is NOT an issue I should bring up with the developers. @andrewgoz Sorry to hijack your thread.

Norwegian-Sardines commented 1 year ago

@Norwegian-Sardines So I understand, reordering the family involving the adopted child, with the change in the labels, as shown in the Latest Demo, is NOT an issue I should bring up with the developers. @andrewgoz Sorry to hijack your thread.

I was responding to the question asked by the OP. Your comment did not make sense to me and continues to not make sense.

zhoueysun commented 1 year ago

@Norwegian-Sardines............ I was responding to the question asked by the OP. Your comment did not make sense to me and continues to not make sense. Thanks for commenting. I wish to retract any concerns and will not bring this up with the developers