fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
429 stars 294 forks source link

Convert tab table to bootstrap grid #4854

Closed ddrury closed 1 year ago

ddrury commented 1 year ago

Proof of concept - Do not use for production

This only works on the webtrees theme for the Individual facts and events tab, (other things will break!!!)

I think this is suitable for production now

I've replaced the containing table with a bootstrap grid. This fixes all the problems with content overflowing the right margin and even looks reasonable when the browser width is reduced such that the columns fold.

It only requires two new webtrees classes, primarily for theming, everthing else is pure bootstrap.

I'd appreciate comments particularly on whether it's worth continuing down this path

BTW I've included a fix for https://github.com/fisharebest/webtrees/issues/4853

codecov[bot] commented 1 year ago

Codecov Report

Merging #4854 (2b4711d) into main (f8b2097) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4854      +/-   ##
============================================
- Coverage     30.96%   30.96%   -0.01%     
  Complexity    11366    11366              
============================================
  Files          1168     1168              
  Lines         47870    47873       +3     
============================================
  Hits          14825    14825              
- Misses        33045    33048       +3     
Impacted Files Coverage Δ
app/Module/IndividualFactsTabModule.php 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

ddrury commented 1 year ago

Closed - will resubmit more complete and simplified code