fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
429 stars 294 forks source link

1931 Canadian Census #4875

Closed manf0001 closed 10 months ago

manf0001 commented 10 months ago

The Canadian 1931 Census is digitized and starting to be seen online at Ancestry or the Canadian Archives for download. Adding that year to webtrees.

fisharebest commented 10 months ago

Could you also add/update the corresponding test scripts?

They should be pretty straightforward. Just look at one of the other test scripts.

Thanks!

manf0001 commented 10 months ago

sorry, I didn't know about the test scripts.. will work on that, then uploaded and issue a PR for it ASAP

codecov[bot] commented 10 months ago

Codecov Report

Merging #4875 (8b41848) into main (a7b47bd) will increase coverage by 0.08%. Report is 7 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head 8b41848 differs from pull request most recent head 724c6dc. Consider uploading reports for the commit 724c6dc to get more accurate results

@@             Coverage Diff              @@
##               main    #4875      +/-   ##
============================================
+ Coverage     30.97%   31.06%   +0.08%     
- Complexity    11377    11379       +2     
============================================
  Files          1169     1170       +1     
  Lines         47887    47929      +42     
============================================
+ Hits          14835    14890      +55     
+ Misses        33052    33039      -13     
Files Changed Coverage Δ
app/Census/CensusColumnNationality.php 100.00% <ø> (ø)
app/Census/CensusOfCanada.php 100.00% <100.00%> (+100.00%) :arrow_up:
app/Census/CensusOfCanada1931.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

fisharebest commented 10 months ago

Thanks! This will be included in the next release.