search

fisharebest / webtrees

Online genealogy
https://webtrees.net
GNU General Public License v3.0
429 stars 294 forks source link

Advanced Search for Place of Marriage not working #4887

Closed rgdobie closed 5 months ago

rgdobie commented 9 months ago

Using the demo of the Royal Family, I searched for a Place of Marriage of 'City of Westminster, London, England'.
I expected this to return the records for Elizabeth II and her husband but instead got a 'no results found'.

photon-flip commented 9 months ago

Seems like it doesn't like the punctuation. City of Westminster London England works. Maybe something to be improved.

rgdobie commented 9 months ago

Wow, so quick, I am impressed!

There may be a further issue when people have been married more than once.

Searching without punctuation in my own tree (VERSION 2.1.17), I found:

. one person whose first marriage was found but not their second

. two persons whose second marriage was found but not the first

. one person whose first and second marriages were found.

Regards

Richard

From: photon-flip @.> Sent: Tuesday, 3 October 2023 2:18 PM To: fisharebest/webtrees @.> Cc: rgdobie @.>; Author @.> Subject: Re: [fisharebest/webtrees] Advanced Search for Place of Marriage not working (Issue #4887)

Seems like it doesn't like the punctuation. City of Westminster London England works. Maybe something to be improved.

— Reply to this email directly, view it on GitHub https://github.com/fisharebest/webtrees/issues/4887#issuecomment-1744100114 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ3VSKGVDSKVKK225VW6E4TX5N7X3AVCNFSM6AAAAAA5QJX3NKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBUGEYDAMJRGQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AQ3VSKAI7QUU7P752SLGDGLX5N7X3A5CNFSM6AAAAAA5QJX3NKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTH6TNRE.gif Message ID: @. @.> >

photon-flip commented 9 months ago

Hi Richard, my reply might have been quick but unfortunately I don't have a quick fix for this. Something for the PHP wizards to tackle. MurrayJ

magicsunday commented 8 months ago

I can't reproduce this. Looks good to me.

grafik

rgdobie commented 8 months ago

Hi magicsunday. My apologies for not mentioning in the body of the email (only in the heading) that this is an issue with the Advanced Search, not the General Search.

fisharebest commented 5 months ago

The search indexes are created for each level of a place-name. Thus City of Westminster, London, England creates three separate indexes - City of Westminster, London and England.

The advanced search expects you to type one of these three.

Of course, this can lead to ambiguity. For example Georgia will match both the country and the US state.

This is not very intuitive. We can provide an input field with auto-complete that selects fully-qualified placenames.

rgdobie commented 5 months ago

Hi fisharebest, further to this I logged into the Royal Family as moderator: I changed the place of marriage for Elizabeth II to sydney, new south wales, australia. I advance searched for place of marriage of sydney. No result.

I changed the place of birth for Elizabeth II to newcastle, new south wales, australia I advance searched for place of marriage of sydney. No result.

I changed the place of birth for Elizabeth II to sydney, new south wales, australia I advance searched for place of marriage of sydney. and the record for Elizabeth II was returned.

Is it possible that for marriages the wrong index is being searched (i.e. the birth index instead of the marriage index)?

Thanks, Regards Richard

fisharebest commented 5 months ago

It looks like the update-script on the demo server had crashed, so you weren't seeing the new code.

Try again now. Searching for "born in greece" and "married in england" gives the Duke of Edinburgh, as expected.

rgdobie commented 5 months ago

Hmm...When I advance search for place of marriage as CIty of Westminster I get 5 marriages but in the Marriages report, I get 8.

fisharebest commented 5 months ago

That looks like a copy/paste error in the code. Fixed.

We now see 16 in the search (because it finds individuals) and 8 in the report (because it finds families).

rgdobie commented 5 months ago

Just tried in the latest Beta. That looks much better (though I got 18 and 9 hits rather than 16 and 8) and the dropdown is a nice touch. There may be an issue with the dates as well. I searched with a date of birth of LONDON (ridiculous input, I know) but I got 206 hits. I tried with a DOB of DEC and also got 206 hits. 14 DEC also gave 206 hits. DEC 1895 gave one hit as did 14 DEC 1895.