search

fisher60 / friendo-bot

A Discord Bot that is just a good Friendo
MIT License
25 stars 24 forks source link

Dice command needs default args and better variable naming #183

Open fisher60 opened 3 years ago

fisher60 commented 3 years ago

The variable n should be renamed to quantity to match the help description. These should also be passed as default args, probably one six-sided dice as default.

Ajay-Singh-Rana commented 3 years ago

Which file are these chnages to be made in..?

fisher60 commented 3 years ago

@Ajay-Singh-Rana Helllo, this issue is pretty much just to clean up this function https://github.com/fisher60/Friendo_Bot/blob/405a25062cd7201d2392c50567b708fa9d14fca0/bot/cogs/fun.py#L162

MS-Ignis commented 3 years ago

hey i fixed this in a pull request just now. please review and merge thanks