fisherjacobc / Roblox-Discord-RPC

MIT License
0 stars 1 forks source link

Recommendation #1

Open xhayper opened 1 year ago

xhayper commented 1 year ago
fisherjacobc commented 1 year ago

👋 Hi there! I have seen your suggestions and have some comments for them

xhayper commented 1 year ago

You actually don't need any scope at all, it just work out of the box (both mine and older one).

xhayper commented 1 year ago

also my discord rpc provides a much better development experience as the error points out to the correct place, and it comes with typing out of the box.

My version also supports snap store and flatpak out of the box (if you don't know, studio can be run via wine now (linux))

xhayper commented 1 year ago

Another thing, transport should be hardcoded to ipc as websocket never work

fisherjacobc commented 1 year ago

You actually don't need any scope at all, it just work out of the box (both mine and older one).

I dont see much advantage to switch now as the default one works out of box, considering you switch it to IPC

also my discord rpc provides a much better development experience as the error points out to the correct place, and it comes with typing out of the box.

Not sure what you mean about the errors, and since this isnt typescript (which i prefer, but make it easier with just js for learners) it doesnt come with many advantages

My version also supports snap store and flatpak out of the box (if you don't know, studio can be run via wine now (linux))

I don't understand how this is related because the studio plugin sends http requests so I don't think its effected by platform unrelated by glad to hear you can run studio with wine!

Another thing, transport should be hardcoded to ipc as websocket never work

Yes, I know that websocket doesnt work

xhayper commented 1 year ago

I don't understand how this is related because the studio plugin sends http requests so I don't think its effected by platform

The way the rpc lib connect to discord is by using path, and since discord-rpc doesn't handle flatpak or snapstore version of discord's path correctly, it means that flatpak / snapstore version of discord won't work on discord-rpc, that is the reason why i bring up wine, since some linux user use roblox studio and using flatpak / snapstore version of discord won't have the rpc. there's a workaround for this but it require the user to do a symlink