fisheva / Eva-Theme

A comfortable and semantic theme.
https://marketplace.visualstudio.com/items?itemName=fisheva.eva-theme
MIT License
457 stars 38 forks source link

fix `with` and `as` keyword for markdown code block #113

Closed sharpchen closed 10 months ago

sharpchen commented 10 months ago

Scopes

keyword scope
with keyword.operator.expression.with.cs
as keyword.operator.expression.as.cs

Code sample

Bar a = new(default);
if (a is IFoo)
{
    var c = a as IFoo;
    a.Bar();
}
var b = a with { Baz = default };

interface IFoo
{
    void Bar();
}
record class Bar(object Baz) : IFoo
{
    public void Bar() { }
}

Before vs After

Before After
image image
fisheva commented 10 months ago

In my memory, markdown code blocks did not have scope values. They might have been added in some later versions of VSCode. Yes, I haven't tested the display effects of each programming language in Markdown code blocks. The positions where you added the scope values are correct, but I want to change the color of with to #CF68E1(the same as as). I expect to update Eva Theme tomorrow.

sharpchen commented 10 months ago

It's ok if you are not ready for a new release, I don't want to bother, these are just minor changes.

fisheva commented 10 months ago

Updated. Don't think that way, all your pull requests are not disturbances, but contributions to the Eva Theme : )