search

fisheva / Eva-Theme

A comfortable and semantic theme.
https://marketplace.visualstudio.com/items?itemName=fisheva.eva-theme
MIT License
451 stars 38 forks source link

Fix Font of unused imports & variables #23

Closed widdydev closed 5 years ago

widdydev commented 5 years ago
Screenshot 2019-04-07 16 15 17

On Line 6 I have an unused import, which i did not know, because i couldn't read the line. It seems that this does have a strange font and color behavior. It is helpful, that it is using underscores to highlight it, but an additional greyed out font would be the best.

Awesome Theme though!

fisheva commented 5 years ago

The VSCode 1.3.3 update caused this problem, I just made a correction, please update the Eva Theme to version 0.7.6 to see if the problem is solved. If you still have questions, let me know.

widdydev commented 5 years ago

Thanks for the quick fix. Now it behaves as expected!

fisheva commented 5 years ago

Sorry, I can't display unused import in a uniform gray font, because their scope value is the same as the used import.

I can only change the transparency of the unused import through the "editorUnnecessaryCode.opacity" API.

And because there is already an underline mark, so I didn't reduce the transparency of the unused import.

widdydev commented 5 years ago

No problem, the implementation with the underline mark is totally fine