search

fisheva / Eva-Theme

A comfortable and semantic theme.
https://marketplace.visualstudio.com/items?itemName=fisheva.eva-theme
MIT License
452 stars 38 forks source link

Console colors on light theme #29

Closed nezaboravi closed 3 years ago

nezaboravi commented 4 years ago

I love the theme and using it for a while now. However, only thing that bothers me is console in vscode. Here is the phto attacHed I am on macosx, default terminal is zshrc. Any suggestion how to get colors properly and nice, please let me know

Screenshot 2019-09-24 19 02 09
fisheva commented 3 years ago

@nezaboravi Sorry to reply to you after so many days, your message is very sincere, which makes me very self-blame.

I wanted to explain why I haven't updated Eva Theme for a long time, what happened during this period, and what I did. But no matter what I say, it seems to be an excuse. So I just want to say: "I'm sorry! Very very sorry!"

Come back to your question. I don't have much experience with Terminal, and Microsoft's official documents are very vague, so I don't know the correspondence between those APIs and the text in Terminal.

The content submitted by netizens in issue#35 gave me some hints. I have adjusted the colors of those Terminal APIs, I added transparency to these background colors. Hope it works.

If you are still using Eva Theme, please update Eva Theme to the latest version.

If you still have any questions, please give me feedback. I won’t reply so late like this time.

fisheva commented 3 years ago

I update my reply to tell you about my new progress in Terminal customization.

I find:

  1. There is no uniform rule for "terminal.ansiColor" and "terminal.ansiBrightColor" as background color or text color.
  2. Neither of these two kinds of API can set the color with transparency.
  3. VSCode sets two default colors for each of these two kinds of API. The overlay relationship between the color set by the user and the two default colors is:
    • When the user does not set: API displays the default color A;
    • When the user sets a solid color without transparency, the API displays the solid color set by the user;
    • When the user sets a color with transparency, the API displays the default color B.

According to the above rules, I set a different solid color for each API in version 0.9.3 and got the first round of feedback in issue #37. I found the corresponding positions of some APIs in Terminal through the screenshots he sent me and made corresponding modifications, then reach the first more complete version of Terminal in 0.9.8.

But there are still some APIs that are not shown in issue #37. I marked them with a red box in the picture below. If you find these colors in the Terminal and feel improper, please give me feedback. image image

In addition, if you find that the text color and the text background color in a place are two similar colors (such as "terminal.ansiBlue" and "terminal.ansiBrightBlue", "terminal.ansiGreen" and "terminal.ansiBrightGreen"), the text is not clear, please give me feedback too. image Thanks!

fisheva commented 2 years ago

Hello! Since of issue 58, I made some changes to the APIs' colors of terminal in version 1.6.4. If you find that after the change, some words under terminal cannot be seen clearly or the background color is inappropriate, please let me know and provide screenshots for me to modify. Thank you!