fisheva / Eva-Theme

A comfortable and semantic theme.
https://marketplace.visualstudio.com/items?itemName=fisheva.eva-theme
MIT License
452 stars 38 forks source link

Shouldn't a C++ Class constructor be of same color as destructor? #41

Closed REYNEP closed 3 years ago

REYNEP commented 3 years ago

Detructor is the opposite of Class Constructor.... Shouldn't they be of same color then? (+Italic)

The class constructor _GHOSTSystemWin32 's color comes from the scope:- entity.name.function.definition.special.constructor.cpp which is set to "foreground": "#CF68E1" (and also this is italic) But the class destructor _~GHOSTSystemWin32 gets it's color from entity.name.function

Class Destructors have a separate scope available:- entity.name.function.definition.special.member.destructor.cpp These constructor and destructor ends with .cpp in their scope, As C doesn't support creating Classes,

image

fisheva commented 3 years ago

Thanks for report. Have fixed in 1.0.3 version.

"entity.name.function.definition.special.constructor.cpp", when I added this scope, I should have met a certain code like the "public" character in the picture is not displayed correctly. Then it also affected the Class Constructor. Now I delete this scope first, and when I met that kind of code again, I will add a more detailed scope.

REYNEP commented 3 years ago

@fisheva, Wait, so You are you talking about when you added the constructor's scope to the rule, and why you did that was because of some kind of mismatch of scope with "public", right?

Sorry about writing the title in reverse way.... ๐Ÿ˜… I really liked the Purple Color and the italic style, the constructor had before ๐Ÿ˜ƒ. But It's Okay if making it blue makes more sense in terms of syntax....

(Sorry, for replying this late Me and My Friend Updated GPU, had to install windows, His all SATA Ports (Except 1) got covered by GPU, so had to exchange Stuffs with other people, did some benchmarks and tasted some games that I couldn't afford before)

fisheva commented 3 years ago

Yes, that's it ๐Ÿ˜ƒ.

(Last time, I didn't know the effect you wanted to modify, so I have been waiting for your reply. As long as you clearly describe the problem and the desired effect when you raise an issue, it doesnโ€™t matter how late you reply.)