fisheva / Eva-Theme

A comfortable and semantic theme.
https://marketplace.visualstudio.com/items?itemName=fisheva.eva-theme
MIT License
452 stars 38 forks source link

C++ function calls look different than C function calls #43

Closed REYNEP closed 3 years ago

REYNEP commented 3 years ago

[NOTE: I DON'T HAVE MS-C/C++ INSTALLED]

C++ functions Calls:- image

Renamed the File to C:- image

In C, meta.function-call.c and entity.name.function.c is set to { "foreground": "#56B7C3", "fontStyle": "italic" } image

In C++, entity.name.function is set to { "foreground": "#6494ED", "fontStyle": "" } image

I Guess Eva-Theme Does use {"foreground": "#56B7C3"} for Function Calls, I checked python....

Then I checked Languages like lua, ruby, js, java, Function Calls (Their colors are not like Python's and C's Color) JS and JAVA function calls get it's color from entity.name.function even though in both languages functions calls have meta.function-call which is the scope that python function call gets color from

in lua, vscode textmate scope only adds support.function.any-method.lua and both lua and ruby function calls gets their color from support.function

REYNEP commented 3 years ago

[NOTE: I DON'T HAVE MS-C/C++ INSTALLED, HATE THAT ADDON]

fisheva commented 3 years ago

@REYNEP I apologize for this late reply.

In C, the scope rule "meta.function-call.c entity.name.function.c" was originally added to distinguish between user-defined functions and language built-in functions(like "printf()"), but it seems that it can't be done at present. I have removed it. Please update Eva Theme to 1.0.4 .

REYNEP commented 3 years ago

It's Been so Long, and I hadn't replied.... My apology.... It seems like it looks same on C & C++ now.... Thank you

But in Python and some other language meta.function-call is still in play: image image

fisheva commented 3 years ago

It doesn't matter, as long as the font style is consistent in the same language, it's okay.

C and c++ have similar syntax and often call each other, which can be regarded as the same language in the theme configuration.

REYNEP commented 3 years ago

Yeah.... It's Kinda also Like I kind of Like both of the colors.... I personally was also thinking that Python should stay how it is.... 😄