fisheva / Eva-Theme

A comfortable and semantic theme.
https://marketplace.visualstudio.com/items?itemName=fisheva.eva-theme
MIT License
452 stars 38 forks source link

Improve built-in TS/JS inlay hints readability for Eva light themes #64

Closed gulshan closed 2 years ago

gulshan commented 2 years ago

The newly introduced TS/JS inlay hints in VSCode are not quite readable in my eyes- image

The built-in lights themes in Code are showing these inlay hints text in black or dark grey. Can you please have a look?

Thanks for the nice themes!

fisheva commented 2 years ago
WX20210919-223005@2x

This is how this code looks on my computer, maybe you should check if it is caused by other extensions.

WX20210919-223153@2x

If the above method does not work, a universal method is to find the extension folder of VSCode, first move all the extensions out, and then move half of them back, restart VSCode each time, and finally find out which extension is caused.

gulshan commented 2 years ago

These settings has to be enabled in vscode for inlay hints to show up-

"javascript.inlayHints.variableTypes.enabled": true,
"javascript.inlayHints.functionLikeReturnTypes.enabled": true,
"typescript.inlayHints.variableTypes.enabled": true,
"typescript.inlayHints.functionLikeReturnTypes.enabled": true,
fisheva commented 2 years ago

I copied the settings into my VSCode setting.json. And restarted VSCode. But there is still nothing changed.

WX20210920-120619@2x

My email is fishyu_eva@qq.com. Would you mind sending this typescript file to me?

gulshan commented 2 years ago

Some information to reproduce minimally- VSCode version: 1.60.1 (stable-user)

Add 1 line to settings:

"typescript.inlayHints.variableTypes.enabled": true

Test typescript code:

let str = 'hi'

It should look like this with "Eva Light" theme- image

gulshan commented 2 years ago

Also, adding this settings-

 "workbench.colorCustomizations": {
    "editorInlayHint.foreground": "#654"
}

improves the readability: image

fisheva commented 2 years ago

That's really quite strange...

WX20210920-135523@2x WX20210920-135536@2x

These two APIs exist, indicating that there are indeed these settings. According to your screenshots, I will set it like this in the next version. These are CSS property-name colors.

"editorInlayHint.foreground": "#888888" / "#8A97C3"   // Eva Light / Eva Dark
gulshan commented 2 years ago

It looks good now- image

Closing the issue!