fisheva / Eva-Theme

A comfortable and semantic theme.
https://marketplace.visualstudio.com/items?itemName=fisheva.eva-theme
MIT License
452 stars 38 forks source link

Consider darker background in Eva Dark Bold for editor pane #69

Closed rhyek closed 2 years ago

rhyek commented 2 years ago

I made a few customizations via my settings.json in vscode and you can see here what that looks like:

original: image

custom: image

I feel this makes it easier to read source code for me. These are the changes:

"workbench.colorCustomizations": {
  "[Eva Dark Bold]": {
    "editor.background": "#21252B",
    "editorGutter.background": "#21252B",
    "sideBar.border": "#181A1F",
    "editor.lineHighlightBackground": "#282c34",
    "editor.wordHighlightBackground": "#ffffff10",
    "editor.wordHighlightStrongBackground": "#ffffff10",
  }
},
fisheva commented 2 years ago

Thanks for your advice. This issue makes me feel very pleasantly surprised. Because, among the users who raised issues, few people have such a clear understanding of the various settings and APIs of VSCode.

I tried your settings. My personal feeling is that after the editor pane background color is darkened, the font color contrast is higher and it appears clearer. But at the same time, the eyes are tighter. After watching for a long time, the eyes get tired faster. Hmmm, this may be different for everyone.

I found you set "editor.wordHighlightStrongBackground", I think your actual needs should be that the fonts in the background of this API are a bit unclear, so I slightly increased the transparency of this background color in the latest version(1.7.7). Hope you like it : )

rhyek commented 2 years ago

You're right that the preference might be subjective, but I did see a couple other comments asking the same thing in the extension marketplace.

Btw, the hightlight background colors were only something I felt I needed to change after I changed the editor pane background. Didn't feel a need before.

rhyek commented 2 years ago

Btw I just wanted to say that your theme has made me think vscode is finally beautiful now after years of using it professionally.

fisheva commented 2 years ago

Thanks! Some other themes are very beautiful too, just with different styles. Such as Nebula Theme.

image