search

fishfolk / jumpy

Tactical 2D shooter in fishy pixels style. Made with Rust-lang 🦀 and Bevy 🪶
https://fishfolk.org/games/jumpy/
Other
1.59k stars 116 forks source link

Prevent pause menu from interrupting network of online game #1001

Closed MaxCWhitehead closed 1 month ago

MaxCWhitehead commented 1 month ago

Description

Right now the pause menu will stop running game session / network session runner, this can lead to timeouts / disconnects. Perhaps we should not pause the game when pause menu is open in online play, just let it keep running.

Or could consider pausing for all players, but this is more complex + also may lead to frustration if game is repeatedly paused by other players. Rounds are fast / cheap so having other players keep going while in menu seems acceptable to me.

Somewhat related to https://github.com/fishfolk/jumpy/issues/994 (pausing may be used to repro this, but not direct / sole cause)

erlend-sh commented 1 month ago

Yeah, only pausing the single session seems best. We could still let the other players know that a player has paused, e.g. by showing a ⏸️ sign above their character. That way at least there’s a chance of fair play.

MaxCWhitehead commented 1 month ago

Yeah, only pausing the single session seems best. We could still let the other players know that a player has paused, e.g. by showing a ⏸️ sign above their character. That way at least there’s a chance of fair play.

We could also allow pause for everyone as a custom lobby setting or something down the line maybe if desired.

MaxCWhitehead commented 1 month ago

This is fixed, pause in online now keeps game going in background + no longer disconnects network. On full disconnects players are now also notified / given button to leave game.