fishfolk / jumpy

Tactical 2D shooter in fishy pixels style. Made with Rust-lang 🦀 and Bevy 🪶
https://fishfolk.org/games/jumpy/
Other
1.64k stars 118 forks source link

fix: kick bomb randomness #902

Closed nelson137 closed 7 months ago

nelson137 commented 7 months ago

Closes #720

Changes

nelson137 commented 7 months ago

I think this feature is ready for review besides maybe some tweaks to the physics. And since I'm working in this item I want to double check that some of the behavior is still what we want:

https://github.com/fishfolk/jumpy/issues/720#issuecomment-1890843359 (linking this here for continuity)

The bomb will explode on collision with a sliding player or a player's back. I'm not sure if that second part was done because only bouncing off the front of a player makes the logic simpler, but if that's no longer desired I can fix that here too :)

zicklag commented 7 months ago

I think this is good! I'm pretty sure it's supposed to explode off of the back of a player, since they can't reasonably kick it when it's behind them ( maybe 🤷‍♂️ ), but if we want to change that later we can.