fishfolk / jumpy

Tactical 2D shooter in fishy pixels style. Made with Rust-lang 🦀 and Bevy 🪶
https://fishfolk.org/games/jumpy/
Other
1.6k stars 115 forks source link

Default settings changed in game not applied to local settings storage #942

Open MaxCWhitehead opened 4 months ago

MaxCWhitehead commented 4 months ago

Description

IWhen updating build on steamdeck, there is Ragdoll control in settings, but it is set to None. It seems that engine does not handle missing fields in settings when new ones are added. Maybe we need to differentiate specifically between missing input in stored settings and write default, and a none input that was set by player. (Explicitly set none in settings?)

Or we could have a default settings file, and user overrides, and overlay it, that way when game runs it always updates default, to make sure changes are applied correctly.

EDIT: I think the most right thing to do is probably some sort of patch function, overlay/merge could work if just adding stuff, but if renaming, wouldn't cut it.

Workaround:

EDIT: I found that we have a handy dandy reset button in settings, player can hit reset to get default controls, slightly inconvenient but ok for now.

To Reproduce

Not entirely sure - but something like install a old build of game pre-ragdoll, run it, then run ragdoll version, see if ragdoll control setting is set to default or set to none.

EDIT: Also seem to be able to delete the ragdoll lines from storage file and the reboot to simulate this.

Expected Behavior

Settings should reflect default unless overridden by user.

Additional Context

No response

Log Messages

No response