fishfolk / jumpy

Tactical 2D shooter in fishy pixels style. Made with Rust-lang 🦀 and Bevy 🪶
https://fishfolk.org/games/jumpy/
Other
1.6k stars 115 forks source link

feat: port periscope #953

Closed DRuppFv closed 3 months ago

DRuppFv commented 4 months ago

Periscope ported, this closes #151.

It's similar to the musket and is mainly useful if the enemy is higher than you. Used the artwork from #151 but the concept art confused me a bit as it says to be "similar to the musket" but in the art it looks like more a shotgun as it has some bullet spread, but adding a very low bullet spread would be a nice idea here so let me know if you think it should be used.

As it's very similar to the musket, it had a certain amount of code duplication, which I think we could discuss together and come to a decision whether to generalize something elsewhere or whether we want to make adjustments to add more uniqueness to the designs.

shooting_periscope

periscope

erlend-sh commented 3 months ago

As it's very similar to the musket, it had a certain amount of code duplication

That could also make it a good candidate for a Lua implementation. This PR is good as-is, just putting a note in for later.

MaxCWhitehead commented 3 months ago

Awesome!