search

fishfolk / punchy

A 2.5D side-scroller beatemup, made in Bevy
https://fishfolk.github.io/punchy/player/latest
Other
265 stars 32 forks source link

button sounds #236

Closed DRuppFv closed 2 years ago

DRuppFv commented 2 years ago

Note: I removed a lot of code that was not done

Just need help with playing the audio, the audio files are in the PR

DRuppFv commented 2 years ago

I believe it is done. I just need someone to test it (my computer is not making sounds) and tell me if the sound is too loud or low.

64kramsystem commented 2 years ago

They sound ok to me. I would (personal taste) increase the volume a bit, but it's fine as now.

When I click on "Start Game", I don't hear anything; I don't know if this is intended or not (also on Quit, but that's more likely to be intended).

DRuppFv commented 2 years ago

They sound ok to me. I would (personal taste) increase the volume a bit, but it's fine as now.

When I click on "Start Game", I don't hear anything; I don't know if this is intended or not (also on Quit, but that's more likely to be intended).

The quit thing can be easily fixed. Just don't close the game immediately. About the start button, it should just play a different sound, and i don't know the reason. For now, i'll try to fix my computer before updating this PR

DRuppFv commented 2 years ago

@64kramsystem I fixed my computer. The "start game" plays the sound! It's just a different one, if you don't like it, i can change.

About the quit game button... To make this work, it would be necessary to OR put audio code in the "exit" button code OR put "exit" button code in the audio code, and i don't think it would be that cool.

64kramsystem commented 2 years ago

I fixed my computer. The "start game" plays the sound! It's just a different one, if you don't like it, i can change.

Ah! I've noticed it. I'm neutral to whatever is used, however, it's hard to notice.

DRuppFv commented 2 years ago

I fixed my computer. The "start game" plays the sound! It's just a different one, if you don't like it, i can change.

Ah! I've noticed it. I'm neutral to whatever is used, however, it's hard to notice.

It's a "normal" sound of "Start Game" button, you can see something like this in a lot of games like Punchy, but you are right. It would be better if we had a loading screen.

And i just put a new one btw

odecay commented 2 years ago

bors merge

bors[bot] commented 2 years ago

Build succeeded: