fishi0x01 / vsh

vsh - HashiCorp Vault interactive shell and cli tool
MIT License
284 stars 12 forks source link

Support vault tls by cert path #112

Closed meridsa closed 10 months ago

meridsa commented 11 months ago

Allows adding TLS support by setting the certificate path on your filesystem to the VAULT_CERT environment variable.

fishi0x01 commented 10 months ago

Please excuse my late response and thank you for the contribution! Can you force push one more time so the CI request is re-triggered? The request gets deleted after 30 days :see_no_evil:

meridsa commented 10 months ago

Hi, what do you mean by force push? The PR looks open to me.

fishi0x01 commented 10 months ago

The problem is that the CI cannot be triggered because I didnt ack within 30 days https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

I.e., I need a fresh commit to re-trigger it, else the tests wont run on that change.

e.g.,

git commit -a --amend
git push origin vault-tls-support --force-with-lease
meridsa commented 10 months ago

There we go 🛩️ 😄