search

fishi0x01 / vsh

vsh - HashiCorp Vault interactive shell and cli tool
MIT License
284 stars 12 forks source link

Support for Vault Token Helpers #20

Closed yermulnik closed 4 years ago

yermulnik commented 4 years ago

Would be great this super cool tool could leverage https://www.vaultproject.io/docs/commands/token-helper/

fishi0x01 commented 4 years ago

Thank you for the nice idea :+1:

I will try to work on that in the coming days.

yermulnik commented 4 years ago

Appreciate it. Thanks.

fishi0x01 commented 4 years ago

I have created a new release which leverages Vault's token helper mechanism. It works for me and the integration test also looks promising.

Does that fully solve your feature proposal?

yermulnik commented 4 years ago

@fishi0x01 Worked like a charm. Thank you!

yermulnik commented 4 years ago

By the way is there a way to turn off auto-completion completely? It drastically slows down vsh on a big number of items to be completed on a remote Vault clusters.

fishi0x01 commented 4 years ago

Very good point :+1: Currently vsh does not support toggling auto-completion. I opened and linked a new issue. Will try to work on that in the coming days.

yermulnik commented 4 years ago

Thanks a bunch! =)

fishi0x01 commented 4 years ago

@yermulnik fyi: added a new release which does some caching to reduce overall query load. That should improve performance a little.

yermulnik commented 4 years ago

@fishi0x01 Thanks a lot. Appreciate your work and effort.