Closed vikin91 closed 4 years ago
This PR changes the way snapshot versions are created, so that it works on MacOS.
Before this change, VERSION could contain spaces, e.g.:
VERSION
go build -ldflags "-X main.vshVersion=$(VERSION)"
go build -ldflags "-X main.vshVersion=-n v0.5.0"
which caused errors on compilation.
Note that with this PR, snapshot-versions are no longer named with a branch, but:
v0.5.0-2-gc429af6
v0.5.0
v0.5.0-2-gc429af6-dirty
This PR changes the way snapshot versions are created, so that it works on MacOS.
Before this change,
VERSIONcould contain spaces, e.g.:go build -ldflags "-X main.vshVersion=$(VERSION)"go build -ldflags "-X main.vshVersion=-n v0.5.0"which caused errors on compilation.
Note that with this PR, snapshot-versions are no longer named with a branch, but:
v0.5.0-2-gc429af6- 2nd commit after tagv0.5.0- all changes are committedv0.5.0-2-gc429af6-dirty(some changes are staged but not committed)